summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDarren Tucker <dtucker@dtucker.net>2020-07-28 19:40:30 +1000
committerDarren Tucker <dtucker@dtucker.net>2020-07-28 19:40:30 +1000
commit89fc3f414be0ce4e8008332a9739a7d721269e50 (patch)
treef0ad5a121f8328b5e3487310d624b3b36fe04244
parent62c81ef531b0cc7ff655455dd34f5f0c94f48e82 (diff)
Use argv in OSSH_CHECK_CFLAG_COMPILE test.
configure.ac is not detecting -Wextra in compilers that implement the option. The problem is that -Wextra implies -Wunused-parameter, and the C excerpt used by aclocal.m4 does not use argv. Patch from pedro at ambientworks.net, ok djm@
-rw-r--r--aclocal.m43
-rw-r--r--configure.ac1
2 files changed, 4 insertions, 0 deletions
diff --git a/aclocal.m4 b/aclocal.m4
index 0193c3dc..b70856e4 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -15,6 +15,7 @@ AC_DEFUN([OSSH_CHECK_CFLAG_COMPILE], [{
#include <stdlib.h>
#include <stdio.h>
int main(int argc, char **argv) {
+ (void)argv;
/* Some math to catch -ftrapv problems in the toolchain */
int i = 123 * argc, j = 456 + argc, k = 789 - argc;
float l = i * 2.1;
@@ -62,6 +63,7 @@ AC_DEFUN([OSSH_CHECK_CFLAG_LINK], [{
#include <stdlib.h>
#include <stdio.h>
int main(int argc, char **argv) {
+ (void)argv;
/* Some math to catch -ftrapv problems in the toolchain */
int i = 123 * argc, j = 456 + argc, k = 789 - argc;
float l = i * 2.1;
@@ -100,6 +102,7 @@ AC_DEFUN([OSSH_CHECK_LDFLAG_LINK], [{
#include <stdlib.h>
#include <stdio.h>
int main(int argc, char **argv) {
+ (void)argv;
/* Some math to catch -ftrapv problems in the toolchain */
int i = 123 * argc, j = 456 + argc, k = 789 - argc;
float l = i * 2.1;
diff --git a/configure.ac b/configure.ac
index ff741735..81a6e31f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -164,6 +164,7 @@ if test "$GCC" = "yes" || test "$GCC" = "egcs"; then
OSSH_CHECK_CFLAG_COMPILE([-Wformat-security])
OSSH_CHECK_CFLAG_COMPILE([-Wsizeof-pointer-memaccess])
OSSH_CHECK_CFLAG_COMPILE([-Wpointer-sign], [-Wno-pointer-sign])
+ OSSH_CHECK_CFLAG_COMPILE([-Wunused-parameter], [-Wno-unused-parameter])
OSSH_CHECK_CFLAG_COMPILE([-Wunused-result], [-Wno-unused-result])
OSSH_CHECK_CFLAG_COMPILE([-Wimplicit-fallthrough])
OSSH_CHECK_CFLAG_COMPILE([-fno-strict-aliasing])