summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDamien Miller <djm@mindrot.org>2020-06-26 16:07:12 +1000
committerDamien Miller <djm@mindrot.org>2020-06-26 16:07:24 +1000
commit598c3a5e3885080ced0d7c40fde00f1d5cdbb32b (patch)
tree1cc1f15ed29f3b2810bdf092f345d8921f88b5ec
parent976c4f86286d52a0cb2aadf4a095d379c0da752e (diff)
document a PAM spec problem in a frustrated comment
-rw-r--r--auth-pam.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/auth-pam.c b/auth-pam.c
index 5a3ba09b..83238215 100644
--- a/auth-pam.c
+++ b/auth-pam.c
@@ -375,7 +375,11 @@ import_environments(struct sshbuf *b)
error("PAM: pam_putenv: %s",
pam_strerror(sshpam_handle, r));
}
- /* XXX leak env? */
+ /*
+ * XXX this possibly leaks env because it is not documented
+ * what pam_putenv() does with it. Does it copy it? Does it
+ * take ownweship? We don't know, so it's safest just to leak.
+ */
}
#endif
}